Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a getPublishers method to the ROS class #760

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add a getPublishers method to the ROS class #760

wants to merge 2 commits into from
+40 −0

Conversation

hello-amal
Copy link

@hello-amal hello-amal commented Jul 17, 2024 •
edited
Loading

Public API Changes

Add a getPublishers method to the Ros class, which returns all publishers for a topic.

Description

rosapi in rosbridge exposes a /rosapi/publishers service to get all the publishers for a topic. This change exposes that functionality to the ROSlib client.

Note: I tested this in a separate fork with ROS2, which is what I use. I haven't tested it in ROS1 -- hopefully the CI is sufficient for that.

@hello-amal hello-amal mentioned this pull request Jul 17, 2024
Merged
EzraBrooks
EzraBrooks reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about moving this into the Topic class instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzraBrooks EzraBrooks EzraBrooks left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hello-amal @EzraBrooks